Solaris build fails in modules/features2d/src/sift.cpp (Bug #1592)

Added by Pavel Heimlich about 13 years ago. Updated about 13 years ago.

Status:Cancelled Start date:
Priority:High Due date:
Assignee:Vadim Pisarevsky % Done:

0%
Category:build/install
Target version:-
Affected version: Operating System:
Difficulty: HW Platform:
Pull request:

Description

build With Solaris Studio 12.3 on Solaris 11 fails with the below error.
This is because variable length arrays are not part of the c++ standard and studio (unfortunately) does not support it.

The attached patch adds studio to the existing workaround for MSVC

--------------------
cd /opt/test2/packages/BUILD/OpenCV-2.3.1a/i386/OpenCV-2.3.1/build/modules/features2d && /opt/test2/SolarisStudio12.3-solaris-x86-bin/solarisstudio12.3/bin/CC   -Dopencv_features2d_EXPORTS -DHAVE_CVCONFIG_H -DCVAPI_EXPORTS -xO3 -DNDEBUG   -KPIC -I/usr/lib/python2.6/vendor-packages/numpy/core/include -I/opt/test2/packages/BUILD/OpenCV-2.3.1a/i386/OpenCV-2.3.1/. -I/opt/test2/packages/BUILD/OpenCV-2.3.1a/i386/OpenCV-2.3.1/build -I/opt/test2/packages/BUILD/OpenCV-2.3.1a/i386/OpenCV-2.3.1/include -I/opt/test2/packages/BUILD/OpenCV-2.3.1a/i386/OpenCV-2.3.1/include/opencv -I/opt/test2/packages/BUILD/OpenCV-2.3.1a/i386/OpenCV-2.3.1/modules/features2d/include -I/opt/test2/packages/BUILD/OpenCV-2.3.1a/i386/OpenCV-2.3.1/modules/features2d/src -I/opt/test2/packages/BUILD/OpenCV-2.3.1a/i386/OpenCV-2.3.1/build/modules/features2d -I/opt/test2/packages/BUILD/OpenCV-2.3.1a/i386/OpenCV-2.3.1/modules/features2d/../core/include -I/opt/test2/packages/BUILD/OpenCV-2.3.1a/i386/OpenCV-2.3.1/modules/features2d/../imgproc/include -I/opt/test2/packages/BUILD/OpenCV-2.3.1a/i386/OpenCV-2.3.1/modules/features2d/../highgui/include -I/opt/test2/packages/BUILD/OpenCV-2.3.1a/i386/OpenCV-2.3.1/modules/features2d/../flann/include -I/opt/test2/packages/BUILD/OpenCV-2.3.1a/i386/OpenCV-2.3.1/modules/features2d/test -I/opt/test2/packages/BUILD/OpenCV-2.3.1a/i386/OpenCV-2.3.1/modules/features2d/../features2d/include -I/opt/test2/packages/BUILD/OpenCV-2.3.1a/i386/OpenCV-2.3.1/modules/features2d/../ts/include    -D PYTHON_USE_NUMPY=1 -o CMakeFiles/opencv_features2d.dir/src/sift.o -c /opt/test2/packages/BUILD/OpenCV-2.3.1a/i386/OpenCV-2.3.1/modules/features2d/src/sift.cpp
"/opt/test2/packages/BUILD/OpenCV-2.3.1a/i386/OpenCV-2.3.1/modules/features2d/../flann/include/opencv2/flann/defines.h", line 124: Warning: Identifier expected instead of "}".
"/opt/test2/packages/BUILD/OpenCV-2.3.1a/i386/OpenCV-2.3.1/modules/features2d/src/sift.cpp", line 324: Error: An integer constant expression is required within the array subscript operator.

OpenCV-vla.diff (411 Bytes) Pavel Heimlich, 2012-02-07 09:52 pm

Associated revisions

Revision d5723480
Added by Andrey Pavlenko over 11 years ago

Merge pull request #1592 from alalek:ocl_program_cache_update

Revision e8451848
Added by Alexander Alekhin over 11 years ago

Merge remote-tracking branch 'upstream/2.4' into merge-2.4

  • #1538 from StevenPuttemans:bugfix_3283
  • #1545 from alalek:ocl_test_fix_rng
  • #1551 from alalek:cmake_install_win
  • #1570 from ilya-lavrenov:ipp_warn_fix
  • #1573 from alalek:perf_simple_strategy
  • #1574 from alalek:svm_workaround
  • #1576 from alalek:ocl_fix_cl_double
  • #1577 from ilya-lavrenov:ocl_setto_opencl12
  • #1578 from asmorkalov:android_fd_cp_fix
  • #1579 from ilya-lavrenov:ocl_norm
  • #1582 from sperrholz:ocl-arithm-additions
  • #1586 from ilya-lavrenov:ocl_setto_win_fix
  • #1589 from ilya-lavrenov:pr1582_fix
  • #1591 from alalek:ocl_remove_cl_hpp_h
  • #1592 from alalek:ocl_program_cache_update
  • #1593 from ilya-lavrenov:ocl_war_on_double
  • #1594 from ilya-lavrenov:ocl_perf
  • #1595 from alalek:cl_code_cleanup
  • #1596 from alalek:test_fix_run_py
  • #1597 from alalek:ocl_fix_cleanup
  • #1598 from alalek:ocl_fix_build_mac
  • #1599 from ilya-lavrenov:ocl_mac_kernel_warnings
  • #1601 from ilya-lavrenov:ocl_fix_tvl1_and_sparse
  • #1602 from alalek:ocl_test_dump_info
  • #1603 from ilya-lavrenov:ocl_disable_svm_noblas
  • #1605 from alalek:ocl_fixes
  • #1606 from ilya-lavrenov:ocl_imgproc
  • #1607 from ilya-lavrenov:ocl_fft_cleanup
  • #1608 from alalek:fix_warn_upd_haar
  • #1609 from ilya-lavrenov:ocl_some_optimization
  • #1610 from alalek:ocl_fix_perf_kalman
  • #1612 from alalek:ocl_fix_string_info
  • #1614 from ilya-lavrenov:ocl_svm_misprint
  • #1616 from ilya-lavrenov:ocl_cvtColor
  • #1617 from ilya-lavrenov:ocl_info
  • #1622 from a0byte:2.4
  • #1625 from ilya-lavrenov:to_string

Conflicts:
cmake/OpenCVConfig.cmake
cmake/OpenCVDetectPython.cmake
cmake/OpenCVGenConfig.cmake
modules/core/CMakeLists.txt
modules/nonfree/src/surf.ocl.cpp
modules/ocl/include/opencv2/ocl/ocl.hpp
modules/ocl/include/opencv2/ocl/private/util.hpp
modules/ocl/perf/main.cpp
modules/ocl/src/arithm.cpp
modules/ocl/src/cl_operations.cpp
modules/ocl/src/cl_programcache.cpp
modules/ocl/src/color.cpp
modules/ocl/src/fft.cpp
modules/ocl/src/filtering.cpp
modules/ocl/src/gemm.cpp
modules/ocl/src/haar.cpp
modules/ocl/src/imgproc.cpp
modules/ocl/src/matrix_operations.cpp
modules/ocl/src/pyrlk.cpp
modules/ocl/src/split_merge.cpp
modules/ocl/src/svm.cpp
modules/ocl/test/main.cpp
modules/ocl/test/test_fft.cpp
modules/ocl/test/test_moments.cpp
modules/ocl/test/test_objdetect.cpp
modules/ocl/test/test_optflow.cpp
modules/ocl/test/utility.hpp
modules/python/CMakeLists.txt
modules/ts/include/opencv2/ts.hpp
modules/ts/src/ts_perf.cpp
samples/android/face-detection/jni/DetectionBasedTracker_jni.cpp

History

#1
Updated by Vadim Pisarevsky about 13 years ago

all the Solaris-related build problems are now in ticket #1542.

  • Status changed from Open to Done
  • (deleted custom field) set to duplicate

#2
Updated by Andrey Kamaev about 13 years ago

  • Status changed from Done to Cancelled
  • Description changed from build With Solaris Studio 12.3 on Solaris 11 fails with the below error. This... to build With Solaris Studio 12.3 on Solaris 11 fails with the below error. This... More

Also available in: Atom PDF