uint in test_lsd.cpp (Bugfix #3205)

Added by Claudio Caraffi over 11 years ago. Updated over 11 years ago.

Status:Done Start date:2013-08-08
Priority:Normal Due date:
Assignee:- % Done:

100%
Category:imgproc, video
Target version:2.4.7
Affected version:branch 'master' (2.9) Operating System:Windows
Difficulty: HW Platform:x86
Pull request:https://github.com/Itseez/opencv/pull/1247

Description

File test_lsd.cpp uses non-standard uint. Won't compile in Mingw 4.7.2 (for example) Replaced with unsigned int, attachment need to be committed.

test_lsd.cpp (6.9 kB) Claudio Caraffi, 2013-08-08 05:54 pm

Associated revisions

Revision 1a42dd90
Added by Steven Puttemans over 11 years ago

Added fixes mentioned in #3205 : changing uint to unsigned literals for compilation on Mingw 4.7.2

Revision 8d61ecbc
Added by Vadim Pisarevsky over 10 years ago

Merge pull request #3205 from parafin:ximea_unix-3.0

History

#1
Updated by Victor Kocheganov over 11 years ago

Hello Claudio,

thank you for your patch. That is great that you've solved the issue by yourself! Also could you please add this patch as a Pull Request to resolve the issue completely? (Please see http://code.opencv.org/projects/opencv/wiki/How_to_contribute for details).

Thank you in advance,
Victor.

  • Category set to imgproc, video
  • Target version set to 2.4.7
  • Assignee set to Claudio Caraffi

#2
Updated by Steven Puttemans over 11 years ago

Give me a shout if you do not have the time to create a pull request.
I will gladly apply the fix and submit one for you.

#3
Updated by Steven Puttemans over 11 years ago

Since I had 5 minutes left, I created a small pull request for this: https://github.com/Itseez/opencv/pull/1247
It would be nice if you could keep track of bugs popping of after buildbot compilation and suggest changes if they happen.

  • Status changed from Incomplete to Open

#4
Updated by Victor Kocheganov over 11 years ago

Steven,

thank you very much for Pull Request! We are in progress of reviewing it.

  • Pull request set to https://github.com/Itseez/opencv/pull/1247

#5
Updated by Steven Puttemans over 11 years ago

Pullrequest merged, bug fixed!

  • Assignee deleted (Claudio Caraffi)
  • Status changed from Open to Done
  • % Done changed from 90 to 100

#6
Updated by Claudio Caraffi over 11 years ago

Sorry, I am still new and I had apparently not set correctly email notifications... Thanks for taking care of that!

#7
Updated by Steven Puttemans over 11 years ago

You are welcome. Somehow the email notification don't work for me either, even if I set the option. Checking up on your own topic is probably the best way to go.

#8
Updated by Claudio Caraffi over 11 years ago

Indeed, even now I keep not receiving email notifications...

#9
Updated by Steven Puttemans over 11 years ago

Same goes for me ... Maybe the service is broken :P

Also available in: Atom PDF