cap_dshow.cpp forgotten validity check (Bug #3044)

Added by Radek Svoboda almost 12 years ago. Updated over 11 years ago.

Status:	Done	Start date:
Priority:	Normal	Due date:
Assignee:	Alexander Smorkalov	% Done:	0%
Category:	highgui-video
Target version:	2.4.6
Affected version:	2.4.5 (latest release)	Operating System:	Windows
Difficulty:		HW Platform:	x86
Pull request:	https://github.com/Itseez/opencv/pull/970

Description

Hi, in cap_dshow.cpp, line 3198 in opencv 2.4.5. source code,

VI.getPixels( index, (uchar*)frame->imageData, false, true );
return frame;

there is a forgotten check to see whether grabbing the image was successful in videoInput lib (return value of VI.getPixels(...) function).
Consider updating to

if (VI.getPixels( index, (uchar*)frame->imageData, false, true ))
return frame;
else
return NULL;

This problem causes undetectable frame stuck (in my case after 4 days of running), because the image is not updated
because of error in videoinput or directshow but the OpenCV considers it OK.

Radek