traincascade/imagestorage.cpp (Feature #194)

Added by Giuseppe Passino almost 15 years ago. Updated almost 13 years ago.

Status:Done Start date:
Priority:Normal Due date:
Assignee:Maria Dimashova % Done:

0%
Category:core
Target version:-
Difficulty: Pull request:

Description

Dear all,

There are two issues with imagestorage.cpp. The first is that when the negatives data file is passed without a directory path, the home directory is extracted wrongly (the name of the file is included instead of the empty string).

The second one is that the return value of fread is not checked, which triggers warnings when complied with gcc 4.4.1.

I created a patch which fixes the errors.

Best wishes,

Giuseppe

filestorage_patch.diff - patch for filestorage.cpp (2.2 kB) Giuseppe Passino, 2010-03-17 12:25 pm

Associated revisions

Revision 64bed206
Added by Andrey Kamaev over 12 years ago

Merge pull request #194 from asmorkalov/v4l_fix

Patch #2323 applied

Revision 5558bf7b
Added by Alexander Alekhin over 10 years ago

Merge pull request #194 from mlyashko:moments

History

#1
Updated by Maria Dimashova almost 15 years ago

Fixed in r2886.
Thanks to Giuseppe.

  • Status changed from Open to Done
  • (deleted custom field) set to fixed

#2
Updated by Andrey Kamaev almost 13 years ago

  • Category set to core
  • Assignee set to Maria Dimashova

Also available in: Atom PDF