cvCreateTrackbar patch to fix setting value of trackbar range (Patch #941)


Added by NILADRI GHOSH almost 15 years ago. Updated about 12 years ago.


Status:Done Start date:
Priority:Low Due date:
Assignee:Vadim Pisarevsky % Done:

0%

Category:highgui-gui
Target version:2.4.3
Affected version: Operating System:
Difficulty: HW Platform:
Pull request:

Description

OS: Win32
Compiler: VS 2010
File: highgui/src/window_w32.cpp
Function: icvCreateTrackbar

The range of the trackbar was being set using windows message type TBM_SETRANGE which combines the 'min' and 'max' of the range into a single DWORD. This leaves just 16 bits for each of the 'min' and 'max' range values, and leads no erroneous functioning of the trackbar in case of 'max' value being greater than 0xFFFF.

The fix (or better approach) is to use the windows message types TBM_SETRANGEMIN and TBM_SETRANGEMAX so that both the 'min' and 'max' values can have any 32 bit value.


cvCreateTrackbar.patch - cvCreateTrackbar Patch (665 Bytes) NILADRI GHOSH, 2011-03-12 09:16 pm


Associated revisions

Revision 63c94129
Added by Vadim Pisarevsky over 12 years ago

enable huge value range in highgui sliders on Windows (patch #941)

Revision 99340b56
Added by Roman Donchenko almost 12 years ago

Merge pull request #941 from apavlenko:signed_char

Revision 3bfc6974
Added by Roman Donchenko almost 12 years ago

Merge remote-tracking branch 'origin/2.4' into merge-2.4

Merged pull requests:
#890 from caorong:patch-1
#893 from jet47:gpu-arm-fixes
#933 from pengx17:2.4_macfix_cont
#935 from pengx17:2.4_filter2d_fix
#936 from bitwangyaoyao:2.4_perf
#937 from bitwangyaoyao:2.4_fixPyrLK
#938 from pengx17:2.4_surf_sample
#939 from pengx17:2.4_getDevice
#940 from SpecLad:autolock
#941 from apavlenko:signed_char
#946 from bitwangyaoyao:2.4_samples2
#947 from jet47:fix-gpu-arm-build
#948 from jet47:cuda-5.5-support
#952 from SpecLad:jepg
#953 from jet47:fix-bug-3069
#955 from SpecLad:symlink
#957 from pengx17:2.4_fix_corner_detector
#959 from SpecLad:qt4-build
#960 from SpecLad:extra-modules

Conflicts:
modules/core/include/opencv2/core/core.hpp
modules/gpu/CMakeLists.txt
modules/gpu/include/opencv2/gpu/device/vec_math.hpp
modules/gpu/perf/perf_video.cpp
modules/gpuimgproc/src/cuda/hough.cu
modules/ocl/include/opencv2/ocl/ocl.hpp
modules/ocl/src/pyrlk.cpp
samples/gpu/driver_api_multi.cpp
samples/gpu/driver_api_stereo_multi.cpp
samples/ocl/surf_matcher.cpp

History

Updated by Kirill Kornyakov about 13 years ago

  • Tracker changed from Feature to Patch

Updated by Alexander Shishkov almost 13 years ago

  • Priority changed from High to Normal
  • Target version deleted ()

Updated by Alexander Shishkov almost 13 years ago

  • Priority changed from Normal to Low

Updated by Alexander Shishkov almost 13 years ago

  • Target version deleted ()

Updated by Andrey Kamaev over 12 years ago

  • Category changed from highgui-images to highgui-gui

Updated by Vadim Pisarevsky over 12 years ago

  • Target version deleted ()

Updated by Vadim Pisarevsky over 12 years ago

thanks! the patch has been applied in 63c94129

  • Status changed from Open to Done
  • Assignee set to Vadim Pisarevsky

Updated by Andrey Kamaev about 12 years ago

  • Target version set to 2.4.3

Also available in: Atom PDF