features2D/matchers.cpp does not build with Eigen3 (Bug #805)
| Status: | Done | Start date: | |
|---|---|---|---|
| Priority: | High | Due date: | |
| Assignee: |  Maria Dimashova |
% Done: | 0% |
| Category: | features2d | ||
| Target version: | - | ||
| Affected version: | Operating System: | ||
| Difficulty: | HW Platform: | ||
| Pull request: |
Description
Svn version (rev 4468) of features2D/src/matchers.cpp does not compile with Eigen3 (development branch, post beta-2).
maxCoeff (eigen matrix) function takes two parameters, and not only one. Besides, it seems the type of this pointer has changed.
It is also deprecated to include Eigen/Array, as it is now included by Eigen/Core.
The attached diff allows to compile with Eigen3.
However, it has not been tested with Eigen2.
Associated revisions
renamed WITH_EIGEN2 to WITH_EIGEN, fixed compilation error if eigen3 is used (#805)
Merge pull request #805 from pengx17:master_canny_fix
History
Updated by Maria Dimashova about 14 years ago
I have tested your patch with Eigen2 and got compilation errors. Could you modify this patch in order to support both Eigen3 and Eigen2? Thanks.
Updated by Maria Dimashova almost 14 years ago
I found in eigen3.0.0 documentation that maxCoeff with one parameter is supported as before, but Eigen/Array is really deprecated in v3.0.0 and it is fixed in r5228.
Thanks for the bug report.
- Status changed from Open to Done
- (deleted custom field) set to fixed