SIFT detector not fully disabled when building for ARM (Bug #772)


Added by Eugene Khvedchenya about 14 years ago. Updated about 14 years ago.


Status:Done Start date:
Priority:High Due date:
Assignee:Maria Dimashova % Done:

0%

Category:features2d
Target version:-
Affected version: Operating System:
Difficulty: HW Platform:
Pull request:

Description

Hi!

I've detected this problem while building OpenCV for iOS platform.
The problem is in sift.cpp file in the features2d module.

In the begining of this file there are following lines:
#ifdef arm
#define ARM_NO_SIFT
#endif

And #ifndef ARM_NO_SIFT macro which disables compilation of all SIFT detector code if ARM target detected.
But the declaration of the class still accessible and even more - in cv::FeatureDetector class have static method "create" which can construct detectors by well-known name.

When building OpenCV for iOS i get linker errors of unimplemented SIFT detector class.

Solution:
Wrap SIFT detector class definition and cv::FeatureDetector::create function with ifndef ARM_NO_SIFT to prevent usage this class anywhere if targeting to ARM.


Associated revisions

Revision fd1f644e
Added by Maria Dimashova about 14 years ago

fixed #772 (added empty implementation of SIFT class methods throwing exception if ARM)

Revision 5163986e
Added by Andrey Kamaev almost 12 years ago

Merge pull request #772 from gpsinghsandhu:featureDescriptionTutorials

History

Updated by Maria Dimashova about 14 years ago

Fixed in r4608.
Thanks.

  • Status changed from Open to Done
  • (deleted custom field) set to fixed

Also available in: Atom PDF