Fixed some illegal implicitly type conversions between vector and scalar data type. (Patch #3416)
| Status: | Done | Start date: | 2013-12-03 |
|---|---|---|---|
| Priority: | Normal | Due date: | |
| Assignee: | Zhigang Gong |
% Done: | 50% |
| Category: | ocl | ||
| Target version: | 3.0-alpha | ||
| Affected version: | branch 'master' (3.0-dev) | Operating System: | Linux |
| Difficulty: | Easy | HW Platform: | Any |
| Pull request: | https://github.com/Itseez/opencv/pull/1913 |
Description
According to ocl spec 6.2.1:
Implicit conversions between built-in vector data types are disallowed.
We can't implicitly convert a scalar data to a vector data.
This patch fixed the above issue in file modules/ocl/src/opencl/imgproc_threshold.cl.
History
Updated by Daniil Osokin over 11 years ago
Hi Zhigang, thank you for the patch! There is one short step left, please, contribute it through Github (http://code.opencv.org/projects/opencv/wiki/How_to_contribute). It will really help!
- Assignee set to Zhigang Gong
- % Done changed from 0 to 50
- Difficulty set to Easy
- Category set to ocl
- Target version set to 3.0-alpha
Updated by Zhigang Gong over 11 years ago
Thanks for your advice, just submitted the pull request at: https://github.com/Itseez/opencv/pull/1913.
Daniil Osokin wrote:
Hi Zhigang, thank you for the patch! There is one short step left, please, contribute it through Github (http://code.opencv.org/projects/opencv/wiki/How_to_contribute). It will really help!
Updated by Nikita Manovich about 11 years ago
Thank you for the pull request. I have closed the bug because the pull request has been merged,
- Pull request set to https://github.com/Itseez/opencv/pull/1913
- Status changed from New to Done