Error in android.toolchain.cmake (Bugfix #3095)

Added by qwerty qwerty over 11 years ago. Updated over 11 years ago.

Status:Cancelled Start date:2013-06-17
Priority:Normal Due date:
Assignee:Alexander Smorkalov % Done:

0%
Category:android
Target version:2.4.6
Affected version:branch 'master' (2.4.9) Operating System:Android
Difficulty: HW Platform:ARM
Pull request:

Description

I've got an error while using `android.toolchain.cmake` under Windows with CMake 2.8.6.
CMake defines CMAKE_C_COMPILER so the following check near line 1104:

if( NOT CMAKE_C_COMPILER )

fails, which leads to incorrectly setupped CMake flags. To fix it I've just removed `if( NOT CMAKE_C_COMPILER )` with it's closing `endif()`.

Associated revisions

Revision 12c69ad4
Added by Vadim Pisarevsky over 10 years ago

Merge pull request #3095 from vpisarev:restore_ocl_div_mul_and_repeat

History

#1
Updated by Kirill Kornyakov over 11 years ago

Alexander, could you please check if the fix is valid.

  • Assignee set to Alexander Smorkalov
  • Category set to android
  • Target version set to 2.4.6
  • Tracker changed from Patch to Bugfix

#2
Updated by Alexander Smorkalov over 11 years ago

CMAKE_C_COMPILER option can be setup only one during the build. CMAKE_C_COMPILER check guards from reseting it during checks in configuration time or in build time. If CMAKE_C_COMPILER is already setup on the first toolchain execution, it means that you try to set compiler path manually. Such approach conflicts with idea on toolchain itself. If you need to use some custom compiler I recommend you to implement your own toolchain file.

  • Operating System set to Android
  • HW Platform set to ARM
  • Status changed from Open to Cancelled

Also available in: Atom PDF