Bugfix for lkdemo.cpp with "delete all the points" option, now it really delete it (Bugfix #2813)

Added by Nikolay Rogoshchenkov about 12 years ago. Updated almost 12 years ago.

Status:	Done	Start date:	2013-02-18
Priority:	Normal	Due date:
Assignee:	Kirill Kornyakov	% Done:	0%
Category:	samples
Target version:	2.4.6
Affected version:	branch '2.4'	Operating System:
Difficulty:		HW Platform:
Pull request:	https://github.com/Itseez/opencv/pull/801

Description

Don't know how to add request to github, patch you can find in attachment. Thank you.

0001-fix-bug-with-delete-all-the-points-option-now-it-rea.patch (772 Bytes) Nikolay Rogoshchenkov, 2013-02-18 06:47 pm

Associated revisions

Revision e3515386
Added by Kirill Kornyakov almost 12 years ago

#2813 bugfix

Revision 278616ba
Added by Roman Donchenko almost 11 years ago

Merge pull request #2813 from 23pointsNorth:patch-2

History

#1
Updated by Kirill Kornyakov about 12 years ago

Nikolay, thank you for the patch. But still, it would be much better if you could prepare a pull request. It may take a lot of effort first time, but this experience is valuable!

Subject changed from fix bug in lkdemo.cpp with "delete all the points" option, now it really delete it to Bugfix for lkdemo.cpp with "delete all the points" option, now it really delete it
Tracker changed from Bug to Bugfix

#2
Updated by Nikolay Rogoshchenkov about 12 years ago

Kirill Kornyakov wrote:

Nikolay, thank you for the patch. But still, it would be much better if you could prepare a pull request. It may take a lot of effort first time, but this experience is valuable!

I agree with you, could you pls point me to Howto?

When I tied to do a push request to github via TortoiseGit (under Win32) I've got:

git.exe push --progress  "origin" master:master

error: The requested URL returned error: 403 while accessing https://github.com/Itseez/opencv.git/info/refs
fatal: HTTP request failed

git did not exit cleanly (exit code 128) (28673 ms @ 2/19/2013 8:48:06 AM)