CvCaptureCAM_XIMEA update (Patch #2586)

Marian, thank you for the patch!

Please note that if you patch is based on the master branch, this will go to the 2.5 release (~2013, June). But if you think that this update would be useful in 2.4.4 release, I would suggest you to make a pull request to the 2.4 branch.

A lot of minor revisions, and 2.5 may be delayed... Actually GitHub pull requests is the only way to speedup integration process, otherwise this patch may stay here forever (as you see). OpenCV team simply doesn't have enough resources to process all tickets, that's why contributions that could be tested automatically have higher priority.

Hello Marian,

I'm working on integrating the patch to the current OpenCV code so that it can be part of the next version (hopefully OpenCV 2.4.6). But after testing I have found a problem with b/w cameras. I saw images similar to the attached file.

After investigating I found a possible bug in the CvCaptureCAM_XIMEA::open function. There you set format without considering isColor variable. So currently you have:

    // default image format RGB24
    format = XI_RGB24;
    mvret = xiSetParamInt( hmv, XI_PRM_IMAGE_DATA_FORMAT, format);
    if(mvret != XI_OK) goto error;

    // allocate frame buffer for RGB24 image
    frame = cvCreateImage(cvSize( width, height), IPL_DEPTH_8U, 3);

    // check if is color camera
    xiGetParamInt(hmv, XI_PRM_IMAGE_IS_COLOR, &isColor);

I've replaced it with the following code:

    // default image format RGB24
    format = XI_RGB24;

    // check if is color camera
    xiGetParamInt(hmv, XI_PRM_IMAGE_IS_COLOR, &isColor);
    if (!isColor)
    {
        format = XI_RAW8;
    }

    mvret = xiSetParamInt( hmv, XI_PRM_IMAGE_DATA_FORMAT, format);
    if(mvret != XI_OK) goto error;

    // allocate frame buffer for RGB24 or RGB8 image
    frame = cvCreateImage(cvSize( width, height), IPL_DEPTH_8U, (isColor)?(3):(1));

And now it works correctly for me.

So, could you please confirm my fix is correct or possibly provide an updatted patch?

Thanks,
Andrew Senin