CMake message mistakes regarding WITH_CARBON option on Mac (Bug #251)

Added by Ryan Lei almost 15 years ago. Updated almost 15 years ago.

Status:Done Start date:
Priority:Low Due date:
Assignee:- % Done:

0%
Category:build/install
Target version:-
Affected version: Operating System:
Difficulty: HW Platform:
Pull request:

Description

in r2968, when I try to enable the option "-D WITH_CARBON=ON", the CMake configuration still tells me:

GUI Back-end:                Cocoa

It turns out to be a mistype in CMakeList.txt, line 1048:
if(APPLE)
message(STATUS "")
if(HAVE_CARBON)
message(STATUS "  GUI Back-end:                Carbon")
else()
message(STATUS "  GUI Back-end:                Cocoa")
endif()
message(STATUS "")
endif()

I think it should be if(WITH_CARBON). It works for me after changing that.

Associated revisions

Revision 4b759422
Added by Vadim Pisarevsky almost 10 years ago

Merge pull request #251 from cbalint13:brisk

History

#1
Updated by anonymous - almost 15 years ago

thanks! fixed in r2999

  • Status changed from Open to Done
  • (deleted custom field) set to fixed

Also available in: Atom PDF