HighGUI DirectShow verbose mode prints wrong flag (Bug #2350)

Added by Ben Buckner over 12 years ago. Updated over 12 years ago.

Status:Done Start date:2012-09-12
Priority:Low Due date:
Assignee:Vadim Pisarevsky % Done:

0%
Category:highgui-video
Target version:2.4.3
Affected version: Operating System:
Difficulty: HW Platform:
Pull request:

Description

Hi

In cap_dshow.cpp the methods videoInput::setVideoSettingCamera and videoInput::getVideoSettingCamera have lines that in verbose mode print the string name of the property flag, but they use getVideoPropertyAsString(Property,propStr) instead of getCameraPropertyAsString(Property,propStr), as they should (because this is a Camera setting in DSHOW rather than a Video setting).
This causes the wrong flag name to be printed for some property flags in verbose mode, which is kind of confusing during debugging. Replacing getVideoPropertyAsString with getCameraPropertyAsString fixes the problem (tested with 2.4.3). Without this change, getCameraPropertyAsString is unused, so I assume the original author just forgot to replace "Video" with "Camera". It's obviously not very important, but I thought I'd pass the fix on.
In 2.5 cap_dshow.cpp (as of this writing) replace
line 1822 

        getVideoPropertyAsString(Property,propStr);

with
        getCameraPropertyAsString(Property,propStr);

and
line 1879
    getVideoPropertyAsString(Property,propStr);

with
    getCameraPropertyAsString(Property,propStr);

(I'd attach the source code, but I can't DL a complete copy of cap_dshow.cpp from the repository right now for some reason.)

Regards,
Ben Buckner

Associated revisions

Revision 40d5b026
Added by Vadim Pisarevsky over 12 years ago

fixed verbose mode in highgui's DirectShow wrapper (bug #2350)

History

#1
Updated by Vadim Pisarevsky over 12 years ago

thanks! your changes have been applied in 40d5b0

  • Status changed from Open to Done
  • Target version changed from 3.0 to 2.4.3

Also available in: Atom PDF