Too large memory buffer in boost.cpp ? (Patch #1803)

Added by Anton Sukhinov almost 13 years ago. Updated almost 13 years ago.

Status:Done Start date:2012-04-16
Priority:Normal Due date:
Assignee:Vadim Pisarevsky % Done:

0%
Category:ml
Target version:2.4.2
Affected version: Operating System:
Difficulty: HW Platform:
Pull request:

Description

May be instead of this line in function CvBoost::update_weights (boost.cpp)

_buf_size += data->buf->step*(sizeof(float)+sizeof(uchar));

should be that one:

_buf_size += data->buf->cols*(sizeof(float)+sizeof(uchar));

?

Related issues

related to Bug #2030: opencv_test_ml fail Done 2012-06-07

Associated revisions

Revision bc541951
Added by Vadim Pisarevsky almost 13 years ago

decreased size of the buffer used in CvBoost::update_weights (ticket #1803)

Revision 4e2ec7b9
Added by Roman Donchenko over 11 years ago

Merge pull request #1803 from ilya-lavrenov:ocl_cvtColor

History

#1
Updated by Andrey Kamaev almost 13 years ago

  • Category set to ml

#2
Updated by Kirill Kornyakov almost 13 years ago

  • Tracker changed from Bug to Patch

#3
Updated by Anton Sukhinov almost 13 years ago

I have noticed that it was fixed in 2.4.1 version I have just downloaded.
Please close the issue.

#4
Updated by Andrey Kamaev almost 13 years ago

boost.cpp was not touched for past two months. This issue has not been addressed.

#5
Updated by Anton Sukhinov almost 13 years ago

That code I refer to was in version 2.3.1.
In 2.4.1 the code is different (many corrections!), and does not have this problem.

#7
Updated by Vadim Pisarevsky almost 13 years ago

thanks! fixed in r8574

  • Target version changed from 3.0 to 2.4.2
  • Assignee set to Vadim Pisarevsky

#8
Updated by Vadim Pisarevsky almost 13 years ago

  • Status changed from Open to Done

Also available in: Atom PDF