cvGetOptimalNewCameraMatrix uses newCameraMatrix before setting it (Patch #1731)

Added by floemker floemker almost 13 years ago. Updated over 12 years ago.

Status:Done Start date:2012-03-30
Priority:Normal Due date:
Assignee:Vadim Pisarevsky % Done:

0%
Category:calibration, 3d
Target version:2.4.2
Affected version: Operating System:
Difficulty: HW Platform:
Pull request:

Description

cvGetOptimalNewCameraMatrix() with centerPrincipalPoint=false calculates IMHO
validPixROI incorrectly, as newCameraMatrix is used here before it is set to the
newly calculated values.

The attached patch should hopefully fix this

getOptimalNewCameraMatrix.patch (664 Bytes) floemker floemker, 2012-03-30 01:03 am

Associated revisions

Revision e918877b
Added by Vadim Pisarevsky over 12 years ago

fixed bug with uninitialized variable in cvGetOptimalNewCameraMatrix (patch #1731 by floemker)

Revision 2767be9a
Added by Andrey Pavlenko over 11 years ago

Merge pull request #1731 from perping:2.4_haar

History

#1
Updated by Andrey Kamaev almost 13 years ago

  • Tracker changed from Bug to Patch
  • Description changed from cvGetOptimalNewCameraMatrix() with centerPrincipalPoint=false calculates IMHO... to @cvGetOptimalNewCameraMatrix()@ with @centerPrincipalPoint=false@ calculates ... More
  • Assignee set to Ilya Lysenkov

#2
Updated by Ilya Lysenkov almost 13 years ago

  • Assignee deleted (Ilya Lysenkov)

#3
Updated by Vadim Pisarevsky over 12 years ago

thanks! this was obviously a bug. your patch was integrated in r8864

  • Target version changed from 2.4.2 to 2.4.3
  • Status changed from Open to Done
  • Assignee set to Vadim Pisarevsky

#4
Updated by Andrey Kamaev over 12 years ago

  • Target version changed from 2.4.3 to 2.4.2

Also available in: Atom PDF