SURF descriptors creation crashes in stitching module. (Bug #1693)

Added by p x almost 13 years ago. Updated almost 13 years ago.

Status:Done Start date:2012-03-16
Priority:High Due date:
Assignee:Alexey Spizhevoy % Done:

0%
Category:stitching
Target version:2.4.0
Affected version: Operating System:
Difficulty: HW Platform:
Pull request:

Description

r7504 brought big changes in features2d.
I try to add nonfree module reference to stitching module to use SURF.
But code crashes in opencv\modules\stitching\src\surf.cpp Line 875 _descriptors.create(.....).
Because _descriptors is a vector<float> defined in opencv\modules\stitching\src\match.cpp Line 354.

Associated revisions

Revision e87a07e2
Added by Alexey Spizhevoy almost 13 years ago

Fixed bug #1693. Also corrected default parameters for stitching.

Revision 92c43a86
Added by Andrey Pavlenko over 11 years ago

Merge pull request #1693 from ilya-lavrenov:ocl_adaptiveBilateralFilter

History

#1
Updated by p x almost 13 years ago

I change the code like this in match.cpp, and it works:
Mat descriptors;
(*surf)(gray_image, Mat(), features.keypoints, descriptors);
features.descriptors = descriptors.reshape(1, (int)features.keypoints.size());

#2
Updated by p x almost 13 years ago

And I add SURF back to stitching module, the performance is very poor, only few of my 50 pictures can be stitched together.
Please test it.
Thank you.

#3
Updated by Alexey Spizhevoy almost 13 years ago

Hi,

I fixed that bug. Thanks. You had poor performance due to recent changes which made some of the default stitching parameters incorrect. Fixed that also.

  • Status changed from Open to Done

#4
Updated by Andrey Kamaev almost 13 years ago

  • Target version set to 2.4.0

Also available in: Atom PDF