cv::circle handles shift parameter incorrectly (Bug #3820)

Added by Goncalo Lopes over 10 years ago. Updated over 9 years ago.

Status:Open Start date:2014-07-18
Priority:Normal Due date:
Assignee:Goncalo Lopes % Done:

0%
Category:core
Target version:-
Affected version:2.4.9 (latest release) Operating System:Any
Difficulty:Easy HW Platform:Any
Pull request:

Description

For filled circles the shift parameter is ignored, unless line type is antialiased.
This can be seen on line 1661 of drawing.cpp:

if( thickness > 1 || line_type >= CV_AA )    
{
... etc

This condition is incorrect.
It should be legitimate to draw a non anti-aliased filled circle with fixed point coordinates and radius.

Suggestion:
if( thickness > 1 || line_type >= CV_AA || shift > 0) {

Associated revisions

Revision 930808c2
Added by Vadim Pisarevsky almost 10 years ago

Merge pull request #3820 from LorenaGdL:patch-1

History

#1
Updated by Dmitry Retinskiy over 10 years ago

Goncalo,

thanks for the suggested correction.
Please put it in the form of pull request for review (see http://www.code.opencv.org/projects/opencv/wiki/How_to_contribute).
Thanks.

  • Status changed from New to Open
  • Category set to core
  • Assignee set to Goncalo Lopes

#2
Updated by Maksim Shabunin over 9 years ago

Issue has been transferred to GitHub: https://github.com/Itseez/opencv/issues/4791

Also available in: Atom PDF