Bug in Core / persistence.cpp (Bug #3811)
| Status: | Cancelled | Start date: | 2014-07-15 |
|---|---|---|---|
| Priority: | Normal | Due date: | |
| Assignee: | Robby Longhorn |
% Done: | 0% |
| Category: | core | ||
| Target version: | - | ||
| Affected version: | 2.4.0 - 2.4.8 | Operating System: | Any |
| Difficulty: | HW Platform: | Any | |
| Pull request: |
Description
The file starts with the line
#define USE_ZLIB 1
FIRST:
It is wrong to define such fundamental definition in a CPP file!
This define should be moved to cvconfig.h where all the other defines are.
SECOND:
When you set this define to zero the compiler complains in several places.
There are several places that must be fixed in this file to remove these compiler errors.
Associated revisions
Merge pull request #3811 from StevenPuttemans:fix_traincascade_getNegatives_master
History
Updated by Steven Puttemans over 10 years ago
Thanks for the report. It seems that you have taken the time to investigate this problem and providing a solution would be easiest if you did by yourself by submitting a pull request.
Are you up to it? More info on http://code.opencv.org/projects/opencv/wiki/How_to_contribute
- Status changed from New to Open
- Category set to core
- Assignee set to Robby Longhorn
Updated by Robby Longhorn over 10 years ago
Sorry, but I don't have the time install the GIT tool, learn how to use it, create a Fork, upload my code,
and all that just for a bug that will be fixed within a minute by any one of you!
Updated by Steven Puttemans over 10 years ago
It is not the fix itself, but the fact that a follow up is needed for each pull request.
If I submit the fix and add you the pull request, are you up for following the discussion on whether this is a good fix or not at the github page?
Updated by Steven Puttemans over 10 years ago
Also if you want it to get fixed under point 2, please provide the code fixes or the file difference.
Updated by Vadim Pisarevsky almost 10 years ago
consider this define as internal-use define, not user-adjustable define. for now ZLIB is a must dependency for opencv
- Status changed from Open to Cancelled