Bug in cap_gstreamer.cpp (Bug #2608)


Added by Bostjan Vesnicer over 12 years ago. Updated about 12 years ago.


Status:Done Start date:2012-12-06
Priority:Normal Due date:
Assignee:Vadim Pisarevsky % Done:

0%

Category:highgui-camera
Target version:2.4.3.2
Affected version: Operating System:
Difficulty: HW Platform:
Pull request:https://github.com/Itseez/opencv/pull/225

Description

I think I found a bug in function CvCapture_GStreamer::open. There is a call

 gst_caps_unref(caps) 
on line 408, but the variable
 caps 
is uninitialized. I think that the solution is to first assign the return value of the
 gst_caps_new_simple(...) 
to the caps variable and only than call into
 gst_app_sink_set_caps(...) 
.


Associated revisions

Revision 05164bf7
Added by Vadim Pisarevsky over 10 years ago

Merge pull request #2608 from Siddharthk:master

History

Updated by Anna Kogan over 12 years ago

Hello Bostjan,

Thank you for reporting the issue. If you can suggest a solution, a patch or pull request there: http://opencv.org/opencv-pull-requests-test-results.html would be highly appreciated!

  • Description changed from I think I found a bug in function CvCapture_GStreamer::open. There is a call ... to I think I found a bug in function CvCapture_GStreamer::open. There is a call ... More
  • Target version set to 3.0

Updated by Éric Piel about 12 years ago

Hello,
I've encountered the same bug. Following the advice of Bostjan, I've fixed the bug.
Following the advice of Anna, I've sent a pull request :-)

Updated by Andrey Kamaev about 12 years ago

  • Target version changed from 3.0 to 2.4.4
  • Pull request set to https://github.com/Itseez/opencv/pull/225

Updated by Andrey Kamaev about 12 years ago

Fixed in 7701fa7

  • Target version changed from 2.4.4 to 2.4.3.2
  • Status changed from Open to Done

Also available in: Atom PDF