Bug in CvModelEstimator2::checkSubset (Bug #2470)

Added by Dajiang Zhang over 12 years ago. Updated about 12 years ago.

Status:Done Start date:2012-10-24
Priority:Normal Due date:
Assignee:Ilya Lysenkov % Done:

0%
Category:calibration, 3d
Target version:2.4.4
Affected version:2.4.3 Operating System:
Difficulty: HW Platform:
Pull request:

Description

In the function CvModelEstimator2::checkSubset, there is this piece of code:

if( checkPartialSubsets )
        i0 = i1 = count - 1;
    else
        i0 = 0, i1 = count - 1;

In this case, when checkPartialSubsets == true, then in the following loop: for( i = i0; i <= i1; i++ )

since i is initialised as i = i0 =i1, then the return value: i >= i1 will always be true. Then this function becomes useless.

Associated revisions

Revision 5021a792
Added by Ilya Lysenkov about 12 years ago

Fixed #2470

Revision c5bf1c10
Added by Andrey Pavlenko almost 11 years ago

Merge pull request #2470 from ilya-lavrenov:tapi_reduction

History

#1
Updated by Evgeny Talanin over 12 years ago

  • Category set to calibration, 3d

#2
Updated by Vadim Pisarevsky about 12 years ago

  • Affected version set to 2.4.3
  • Target version deleted ()

#3
Updated by Ilya Lysenkov about 12 years ago

  • Assignee set to Ilya Lysenkov

#4
Updated by Andrey Kamaev about 12 years ago

Fix is pushed to 2.4

  • Status changed from Open to Done

#5
Updated by Kirill Kornyakov about 12 years ago

  • Target version set to 2.4.4

Also available in: Atom PDF