A patch set to get rid of warnings (Patch #2139)

Added by eunyoung kim over 12 years ago. Updated over 12 years ago.

Status:Cancelled Start date:2012-07-03
Priority:Normal Due date:
Assignee:Andrey Kamaev % Done:

0%
Category:build/install
Target version:2.4.3
Affected version: Operating System:
Difficulty: HW Platform:
Pull request:

Description

Hi,

We have encountered a lot of warnings from OpenCV when we complile it.
Here is a patch set that we generated for those warnings.

Please review and consider to apply on the next version. :)

Best,

Regina

0003-COMP-Silence-unused-variable-warnings.patch (3.1 kB) eunyoung kim, 2012-07-03 09:56 pm

0004-COMP-Remove-hidden-virtual-function-warnings.patch (9.4 kB) eunyoung kim, 2012-07-03 09:56 pm

History

#1
Updated by Kirill Kornyakov over 12 years ago

Andrey, didn't we get rid of such warnings some time ago?

  • Category set to build/install

#2
Updated by Andrey Kamaev over 12 years ago

This patch can not be applied even if this patch fixes something.
  1. It is dirty - adds useless comments and patches files that are not in source tree.
  2. It breaks functionality.

eunyoung, for the case of warnings you'd better provide code samples showing these warnings instead of messy patches.

  • Status changed from Open to Cancelled
  • Target version set to 2.4.3
  • Assignee set to Andrey Kamaev

#3
Updated by eunyoung kim over 12 years ago

Thank you for the fast reply.
Sorry for my sloppy patch. I will double check if the error message is gone for the current version and try to come up with better documentation/patch next time.

I really appreciate for your help and comments.

Best regards,

Regina

Also available in: Atom PDF