INT64_C poorly (re)defined (Patch #2033)


Added by anthony mallet almost 13 years ago. Updated about 12 years ago.


Status:Done Start date:2012-06-08
Priority:Normal Due date:
Assignee:Vadim Pisarevsky % Done:

0%

Category:build/install
Target version:2.4.3
Affected version: Operating System:
Difficulty: HW Platform:
Pull request:

Description

A comment in modules/highgui/src/ffmpeg_codecs.hpp states
"some versions of FFMPEG assume a C99 compiler, and don't define INT64_C". Good.

However, the (re)definition provided is really poor, and probably only works on (some ?) linux systems. For instance, this breaks on netbsd where the opencv code redefine the INT64_C to an empty string, which is obviously wrong.

I suggest using the attached patch.


patch-aa (766 Bytes) anthony mallet, 2012-06-08 02:01 pm


Associated revisions

Revision 0e314163
Added by Vadim Pisarevsky over 12 years ago

fixed INT64_C & UINT64_C definitions (patch #2033)

Revision 0966e5ff
Added by Andrey Pavlenko about 11 years ago

Merge pull request #2033 from ilya-lavrenov:tapi_normalize

History

Updated by Kirill Kornyakov over 12 years ago

Thank you for the proposed patch, we'll consider it!

  • Tracker changed from Bug to Patch

Updated by Vadim Pisarevsky over 12 years ago

  • Target version deleted (2.4.3)
  • Assignee deleted (Alexander Shishkov)

Updated by Vadim Pisarevsky over 12 years ago

thanks! your patch was applied in 0e31416

  • Status changed from Open to Done
  • Assignee set to Vadim Pisarevsky

Updated by Andrey Kamaev about 12 years ago

  • Target version set to 2.4.3

Also available in: Atom PDF