No Support for Xtion Pro Live QVGA Mode (Patch #1753)

Added by David Schwarz almost 13 years ago. Updated about 12 years ago.

Status:Done Start date:2012-04-04
Priority:Normal Due date:
Assignee:Vadim Pisarevsky % Done:

0%
Category:highgui-camera
Target version:2.4.3
Affected version: Operating System:
Difficulty: HW Platform:
Pull request:

Description

Currently, highgui.cpp hardcodes an enum for openNI:

CV_CAP_OPENNI_VGA_30HZ     = 0,
    CV_CAP_OPENNI_SXGA_15HZ    = 1,
    CV_CAP_OPENNI_SXGA_30HZ    = 2

The ASUS Xtion Pro Live supports QVGA, and on top of that, at 60Hz. I think this is a useful feature that should be considered, such that it looks like:

CV_CAP_OPENNI_VGA_30HZ     = 0,
    CV_CAP_OPENNI_SXGA_15HZ    = 1,
    CV_CAP_OPENNI_SXGA_30HZ    = 2,
    CV_CAP_OPENNI_QVGA_30HZ    = 3,
    CV_CAP_OPENNI_QVGA_60HZ    = 4,

And we could call it. If the device does not support these options (like the Kinect), it raises the CV error.

This also applied to the depth generator. I have an ASUS Xtion, and I would be more than happy to test changes if this is implemented. Thanks!

cap_openni.cpp.patch - Support for QVGA for Xtion. (657 Bytes) David Schwarz, 2012-04-13 04:45 am

highgui_c.h.patch - Updated enums. (444 Bytes) David Schwarz, 2012-04-13 04:45 am

openni_capture.cpp.patch (813 Bytes) David Schwarz, 2012-04-13 04:45 am

Associated revisions

Revision a09c88ab
Added by Vadim Pisarevsky over 12 years ago

added Asus Xtion QVGA modes to the OpenNI backend (patch #1753)

Revision 254aece3
Added by Roman Donchenko over 11 years ago

Merge pull request #1753 from abidrahmank:py_tutorials

History

#1
Updated by Kirill Kornyakov almost 13 years ago

Don't you want to provide a patch? It would simplify things a lot. Otherwise it might take too much time even for such a simple feature...

  • Tracker changed from Bug to Feature
  • Target version deleted (2.4.0)
  • Category set to highgui-images

#2
Updated by David Schwarz almost 13 years ago

Silly me. I guess I didn't feel that comfortable delving into the code at the time. I'm more familiar with it, so here's the patch. I tested it with my Xtion, everything works. I also updated the OpenNI sample.

  • File cap_openni.cpp.patch added
  • File highgui_c.h.patch added
  • File openni_capture.cpp.patch added

#3
Updated by Alexander Shishkov almost 13 years ago

  • Assignee set to Alexander Shishkov

#4
Updated by Andrey Kamaev over 12 years ago

  • Category changed from highgui-images to highgui-camera

#5
Updated by Andrey Kamaev over 12 years ago

  • Tracker changed from Feature to Patch

#6
Updated by Vadim Pisarevsky over 12 years ago

  • Target version deleted ()
  • Assignee deleted (Alexander Shishkov)

#7
Updated by Vadim Pisarevsky over 12 years ago

thanks! your patches have been applied in a09c88ab

  • Status changed from Open to Done
  • Assignee set to Vadim Pisarevsky

#8
Updated by Andrey Kamaev about 12 years ago

  • Target version set to 2.4.3

Also available in: Atom PDF