Bug in rectify3Collinear calibration.cpp ? (Bug #1747)


Added by Antonio Albiol almost 13 years ago. Updated about 12 years ago.


Status:Done Start date:2012-04-03
Priority:Normal Due date:
Assignee:Ilya Lysenkov % Done:

0%

Category:calibration, 3d
Target version:2.4.4
Affected version:2.4.3 Operating System:
Difficulty: HW Platform:
Pull request:

Description

In the function definition

 1float cv::rectify3Collinear( InputArray _cameraMatrix1, InputArray _distCoeffs1,
 2                   InputArray _cameraMatrix2, InputArray _distCoeffs2,
 3                   InputArray _cameraMatrix3, InputArray _distCoeffs3,
 4                   InputArrayOfArrays _imgpt1,
 5                   InputArrayOfArrays _imgpt3,
 6                   Size imageSize, InputArray _Rmat12, InputArray _Tmat12,
 7                   InputArray _Rmat13, InputArray _Tmat13,
 8                   OutputArray _Rmat1, OutputArray _Rmat2, OutputArray _Rmat3,
 9                   OutputArray _Pmat1, OutputArray _Pmat2, OutputArray _Pmat3,
10                   OutputArray _Qmat,
11                   double alpha, Size /*newImgSize*/,
12                   Rect* roi1, Rect* roi2, int flags )

the argument after alpha is not given a name. Probably the comment should be removed and the variable newImgSize used accordingly instead of imageSize in the calls:

1stereoRectify( _cameraMatrix1, _distCoeffs1, _cameraMatrix2, _distCoeffs2,
2                   imageSize, _Rmat12, _Tmat12, _Rmat1, _Rmat2, _Pmat1, _Pmat2, _Qmat,
3                   flags, alpha, imageSize, roi1, roi2 );
4
5stereoRectify( _cameraMatrix1, _distCoeffs1, _cameraMatrix2, _distCoeffs2,
6                   imageSize, _Rmat12, _Tmat12, _Rmat1, _Rmat2, _Pmat1, _Pmat2, _Qmat,
7                   flags, alpha, newImgSize, roi1, roi2 );

History

Updated by Andrey Kamaev almost 13 years ago

  • Description changed from In the function definition float cv::rectify3Collinear( InputArray _cameraMat... to In the function definition <pre><code class="cpp"> flo... More
  • Category set to calibration, 3d

Updated by Vadim Pisarevsky over 12 years ago

  • Target version deleted ()

Updated by Kirill Kornyakov over 12 years ago

  • Target version set to Next Hackathon

Updated by Vadim Pisarevsky about 12 years ago

  • Affected version set to 2.4.3
  • Target version deleted (Next Hackathon)

Updated by Ilya Lysenkov about 12 years ago

  • Assignee set to Ilya Lysenkov

Updated by Andrey Kamaev about 12 years ago

Fix is pushed to 2.4: 6feade3

  • Status changed from Open to Done

Updated by Kirill Kornyakov about 12 years ago

  • Target version set to 2.4.4

Also available in: Atom PDF