please consider attached build system patch (Feature #1374)

Added by Andreas K. Huettel over 13 years ago. Updated about 13 years ago.

Status:Done Start date:
Priority:High Due date:
Assignee:Andrey Kamaev % Done:

0%
Category:build/install
Target version:2.4.0
Difficulty: Pull request:

Description

Dear OpenCV developers, please consider integrating some or all of the attached patch. It does:

  • convert the SET cmake commands to OPTIONS so the build can be controlled by cmake command line options
  • add missing libdir suffixes in several places (e.g. lib > lib64)

opencv-2.3.0-convert_sets_to_options.patch (14.2 kB) Andreas K. Huettel, 2011-09-18 08:53 pm

opencv-2.3.1a-convert_sets_to_options.patch - convert sets to options for opencv-2.3.1a (9.6 kB) Andreas K. Huettel, 2011-11-13 03:28 pm

Associated revisions

Revision d6e8216b
Added by Roman Donchenko over 11 years ago

Merge pull request #1374 from zacstewart:2.4

History

#1
Updated by Vadim Pisarevsky over 13 years ago

  • Status deleted (Open)

#2
Updated by Vadim Pisarevsky over 13 years ago

Andrey, if I remember correctly, you gave me some reasons why using "option" in CMake is not always good. Could you put it here, so that we can reference the ticket in future.

#3
Updated by Andrey Kamaev about 13 years ago

Actually Andrey Pavlenko had the problem with cmake "option". But we were not able to reproduce it after a while.
Anyway build options are already controllable from command line and this patch does not make any cmake improvement.

Closing because the most of the "set" commands changed in suggested patch are eventually converted to options in r7113.

  • Status set to Done
  • (deleted custom field) set to fixed

#4
Updated by Andrey Kamaev about 13 years ago

  • Target version set to 2.4.0

Also available in: Atom PDF