Variable name "outliers" in estimateAffine3D misleading, should be "inliers" (Feature #1141)
| Status: | Done | Start date: | |
|---|---|---|---|
| Priority: | Normal | Due date: | |
| Assignee: |  Vadim Pisarevsky |
% Done: | 0% |
| Category: | calibration, 3d | ||
| Target version: | - | ||
| Difficulty: | Pull request: |
Description
In the documentation, the fourth parameter of estimateAffine3D is described as:
"outliers – The output vector indicating which points are outliers"
It took me quite a while of testing and code reading in modelest.cpp to find out that in fact the vector marks the inliers. For each point pair as input the corresponding element of the vector is "1" if the pair was an inlier and "0" otherwise (set in line 81 of modelest.cpp).
I propose the renaming of the variable to "inliers" and to adapt the documentation accordingly.
Associated revisions
corrected estimateAffine3D parameter name: outliers=>inliers (ticket #1141)
Merge pull request #1141 from apavlenko:fix_warning_unreach_code
History
Updated by Vadim Pisarevsky over 13 years ago
thanks! fixed in trunk, r5546
- Status changed from Open to Done
- (deleted custom field) set to fixed