Update FLANN Library (Feature #3249)


Added by Dominik Van Opdenbosch almost 4 years ago. Updated almost 2 years ago.


Status:Open Start date:2013-09-05
Priority:Low Due date:
Assignee:Roman Donchenko % Done:

0%

Category:flann
Target version:Next Hackathon Estimated time:2.00 hours
Difficulty:Easy Pull request:

Description

There are several issues with the FLANN Library which have been fixed in the flann master branch but not pulled
to the OpenCV Code.

https://github.com/mariusmuja/flann/commit/b72d526463e892bfc4eb30bf0c640a3cb5b9bd69#src/cpp/flann/algorithms/lsh_index.h


History

Updated by Anna Kogan almost 4 years ago

Hello Dominik,

Thank you for reporting the problem. If you could make a pull request with those fixes, it would be very appreciated!

  • Assignee deleted (Marius Muja)
  • Status changed from New to Open

Updated by Alexander Smorkalov almost 4 years ago

  • Assignee set to Roman Donchenko
  • Target version set to 2.4.7

Updated by Prasan Samtani almost 4 years ago

I can take a look at this if nobody else is doing so.

It appears that the flann repo on github is significantly different from the module in opencv, is there a reason behind this?

Updated by Guanta Alecho almost 4 years ago

Prasan Samtani wrote:

I can take a look at this if nobody else is doing so.

Cool, this would be great! I'd appreciate an updated version!

It appears that the flann repo on github is significantly different from the module in opencv, is there a reason behind this?

Afaik it's just very outdated.

Updated by Prasan Samtani almost 4 years ago

Alright, I'll try and do so this weekend.

Updated by Alexander Smorkalov over 3 years ago

@Roman Donchenko, please have a look. I believe, that this fix has been already cherry-picked to OpenCV.

  • Affected version changed from branch 'master' (2.9) to 2.4.0 - 2.4.6

Updated by Alexander Smorkalov over 3 years ago

  • Target version changed from 2.4.7 to 2.4.8

Updated by Roman Donchenko over 3 years ago

No, that one wasn't.

Honestly, our copy of FLANN is pretty much unmaintained; there are even plans to ditch it by 3.0. If you (well, anyone reading this) want to cherry-pick some critical fixes, send us a pull request and we could merge it, but a wholesale update is unlikely to happen.

  • Priority changed from Normal to Low

Updated by Alexander Smorkalov over 3 years ago

  • Target version changed from 2.4.8 to Next Hackathon

Updated by Maksim Shabunin about 2 years ago

  • Affected version changed from 2.4.0 - 2.4.6 to branch 'master' (3.0-dev)

Updated by Maksim Shabunin about 2 years ago

  • Tracker changed from Patch to Feature

Updated by Maksim Shabunin almost 2 years ago

Issue has been transferred to GitHub: https://github.com/Itseez/opencv/issues/4621

Also available in: Atom PDF