NetBSD video support / decouple V4L2 from V4L (Patch #2360)


Added by Patrick Welche about 2 years ago. Updated over 1 year ago.


Status:Done Start date:2012-09-17
Priority:Normal Due date:
Assignee:Andrey Kamaev % Done:

0%

Category:highgui-video
Target version:2.4.4
Affected version:branch '2.4' Operating System:
Difficulty: HW Platform:
Pull request:https://github.com/Itseez/opencv/pull/282

Description

A collection of 3 patches which bring NetBSD video(4) support to highgui / VideoCapture.

The first patch is to the build infrastructure, essentially making configure look for sys/videoio.h.
The second patch decouples Video4Linux2 support from Video4Linux version 1 support. (Probably necessary for newer Linux distributions too.)
The third patch deals with the variety of ioctl prototypes.

The patches are against today's git master branch.


0001-NetBSD-video-4-support-patch-1-of-3.patch - build patch (4 kB) Patrick Welche, 2012-09-17 03:36 pm

0002-NetBSD-video-4-support-patch-2-of-3.patch - V4L2 vs V4L patch (15.6 kB) Patrick Welche, 2012-09-17 03:36 pm

0003-NetBSD-video-4-support-patch-3-of-3.patch - xioctl unsigned long patch (2.9 kB) Patrick Welche, 2012-09-17 03:36 pm


Related issues (Add)

related to Bug #2084: Regression in V4L Done 2012-06-25 Delete

History

Updated by Patrick Welche about 2 years ago

Probably fixes issue 2084 too.

Updated by Andrey Pavlenko about 2 years ago

  • Assignee set to Vadim Pisarevsky
  • Category set to highgui-video

Updated by Alexander Smorkalov almost 2 years ago

The second patch breaks the build on Ubuntu 11.4 x64. Please update a patch and provide it via pull request on github: https://github.com/Itseez/opencv

Updated by Kirill Kornyakov almost 2 years ago

Patrick,

As you can see, there are some issues with your patches. It would be great if you can update them and submit in the form of pull request. If you do this, you'll be able to see their build status here: http://pullrequest.opencv.org. Our BuildBot will automatically test them on 3 major operating systems, and this will speedup the merge process.

  • Assignee changed from Vadim Pisarevsky to Patrick Welche

Updated by Patrick Welche almost 2 years ago

Just tried my first pull request:

https://github.com/Itseez/opencv/pull/282

I had a successful build on Ubuntu 12.04.1 x86_64 - I'll be interested in seeing logs of the Ubuntu 11.4 issues...

Updated by Kirill Kornyakov almost 2 years ago

Great, thank you for the pull request! BuildBot is green, so I think the issue is resolved, we'll inform you in case of any issues. The code will be reviewed in the nearest future.

BTW, does your pull request contain all 3 patches that were attached? I'm asking because we need to know if we should close this ticket after your pull request is merged.

  • Pull request set to https://github.com/Itseez/opencv/pull/282

Updated by Patrick Welche almost 2 years ago

I included all 3 patches in the pull request. As a newbie to pull requests, it looks to me as though the buildbot only tried the 3rd patch? Should you see green dots next to all 3 rather than just the last patch?

FYI, in my fork:
patch 3: 38ebc6bbe5b777645c153bf8e239465af3d5ce4c
patch 2: 8b5ba9fcfa69fa69dee8229df9311d77ab8e4c19
patch 1: 64d2dacaf580eed6944bf26e9015cb012809865d

Updated by Andrey Kamaev over 1 year ago

All fixes are pushed to 2.4

  • Assignee changed from Patrick Welche to Andrey Kamaev
  • Status changed from Open to Done
  • Affected version set to branch '2.4'
  • Target version set to 2.4.4

Updated by Andrey Kamaev over 1 year ago

  • Target version deleted (2.4.4)

Updated by Kirill Kornyakov over 1 year ago

  • Target version set to 2.4.4

Also available in: Atom PDF